-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle buddy reporter #4648
Bundle buddy reporter #4648
Conversation
|
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. Three.js x4 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... |
Remove prefix clean independent of graph files. This was leading to a sitation where parcel files were not being matched. parcel-bundler/parcel#4648 This is however still needed for webpack, so this logic is being pushed into the custom transform for webpack ONLY.
You'll need to add the plugin to the default config's package.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a linting issue, other than that looks good
I know this is WIP but can you explain how to actually use this? I set I looked on the bundle buddy repo and npm page for guidance on how to use the tool, and I gathered that I should install |
It's documented here: https://v2.parceljs.org/features/production/ |
Hey all, once you have the generated file you can upload it to https://bundle-buddy.com/ to view the report on your project. The application is still very much in an alpha state :) But it is totally usable. @mattrossman would love to hear your feedback! Thanks all. |
Thanks, I just tried it out. Some initial thoughts:
|
Remove prefix clean independent of graph files. This was leading to a sitation where parcel files were not being matched. parcel-bundler/parcel#4648 This is however still needed for webpack, so this logic is being pushed into the custom transform for webpack ONLY.
Remove prefix clean independent of graph files. This was leading to a sitation where parcel files were not being matched. parcel-bundler/parcel#4648 This is however still needed for webpack, so this logic is being pushed into the custom transform for webpack ONLY.
cc. @samccone
TODO: determine a CLI flag to run this with. right now you run enable it with
BUNDLE_BUDDY=true
as an environment variable.